From 4df4065323101120d9881c6884e612a453b4b63c Mon Sep 17 00:00:00 2001 From: Wei Liu Date: Wed, 8 Apr 2015 17:08:20 +0100 Subject: [PATCH] libxenstat: YAJL_GET_STRING may return NULL Passing NULL to strcmp can cause segmentation fault. Continue in that case. Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson Cc: Charles Arnold Reviewed-by: Andrew Cooper Acked-by: Ian Jackson Acked-by: Ian Campbell --- tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c b/tools/xenstat/libxenstat/src/xenstat_qmp.c index 10ae104ccf..aad15c8196 100644 --- a/tools/xenstat/libxenstat/src/xenstat_qmp.c +++ b/tools/xenstat/libxenstat/src/xenstat_qmp.c @@ -110,7 +110,7 @@ static char *qmp_get_block_image(xenstat_node *node, char *qmp_devname, int qfd) ptr[0] = qblock[QMP_BLOCK_DEVICE]; /* "device" */ if ((dev_obj = yajl_tree_get(n, ptr, yajl_t_any)) != NULL) { tmp = YAJL_GET_STRING(dev_obj); - if (strcmp(qmp_devname, tmp)) + if (!tmp || strcmp(qmp_devname, tmp)) continue; } else -- 2.30.2